REF: refactor implementation of to_dict out of frame.py and into core.methods.to_dict #50253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyafarber
changed the title
|
@rhshadrach friendly ping |
rhshadrach
added
Refactor
|
Thanks @kostyafarber! There are other methods that should now go in this directory - describe is one example. Would you be interested in continuing this kind of refactor? |
|
Hey @rhshadrach no worries, glad I can help - Yeah sure! If you wanna open up an issue with a list of methods, I can open PRs against them and work on it. |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Dec 17, 2022
|
@rhshadrach shall I look into describe or are you compiling a list? Happy to work on describe in the meantime. |
|
@kostyafarber - I don't plan on compiling a list; I think describe would be great to work on. |
|
@rhshadrach |
|
? |
|
@kostyafarber - thanks for the ping; yes, that's correct. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_dictimplementation to pandas.core.methods.to_dict #49845 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Following #46487 (review) a decision was made to move the implementation of
to_dictinframe.pyintopandas.core.methods.to_dict.